On Friday, July 08, 2016 03:43:10 PM Markus Mayer wrote: > Call strtolower() rather than walking the string explicitly to convert > it to lowercase. > > Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx> > --- > > Rafael, I left off your ACK, since the implementation of my function > changed somewhat (doesn't check the argument NULL, doesn't return > anything). Please let me know if you are still okay with this. I am, as long as it doesn't change the result, which seems to be the case. > drivers/acpi/device_sysfs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c > index 7b2c48f..1db38c7 100644 > --- a/drivers/acpi/device_sysfs.c > +++ b/drivers/acpi/device_sysfs.c > @@ -200,12 +200,10 @@ static int create_of_modalias(struct acpi_device *acpi_dev, char *modalias, > const union acpi_object *of_compatible, *obj; > int len, count; > int i, nval; > - char *c; > > acpi_get_name(acpi_dev->handle, ACPI_SINGLE_NAME, &buf); > /* DT strings are all in lower case */ > - for (c = buf.pointer; *c != '\0'; c++) > - *c = tolower(*c); > + strtolower(buf.pointer); > > len = snprintf(modalias, size, "of:N%sT", (char *)buf.pointer); > ACPI_FREE(buf.pointer); > Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
