RE: [UPDATE RFC PATCH v2] ACPI / EC: Fix an order issue in ec_remove_handlers()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> From: Wolfram Sang [mailto:wsa@xxxxxxxxxxxxx]
> Subject: Re: [UPDATE RFC PATCH v2] ACPI / EC: Fix an order issue in
> ec_remove_handlers()
> 
> On Thu, Jul 07, 2016 at 12:37:10PM +0800, Lv Zheng wrote:
> > (Updated to add v2 indicator)
> >
> > There is an order issue in ec_remove_handlers() that the functions
> invoked
> > in it are not invoked in the reversed order of their appearance in
> > ec_install_handlers(). This existing issue has been triggered by the
> > following commit:
> >   Commit: dcf15cbded656a12335bc4151f3f75f10080a375
> >   Subject: ACPI / EC: Fix a boot EC regresion by restoring boot EC
> > The commit invokes ec_remove_handlers() during runtime, thus
> uncovers this
> > issue. This patch fixes this regression.
> >
> > Fixes: dcf15cbded65 ("ACPI / EC: Fix a boot EC regresion by restoring
> boot EC")
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=102421
> > Reported-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> > Reported-by: Nicholas <nkudriavtsev@xxxxxxxxx>
> > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> > Cc: Nicholas <nkudriavtsev@xxxxxxxxx>
> > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
> 
> Tested-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> 
> The status infos are back to normal and the EC error reports are gone
> from the log. Looks good! Thanks for the quick fix.

[Lv Zheng] 
Thanks for the test, I'll refresh the patch with your tested-by added and RFC removed.

Best regards
-Lv
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux