-----Original Message----- From: Dan Williams [mailto:dan.j.williams@xxxxxxxxx] Sent: Thursday, July 07, 2016 3:49 AM To: Johannes Thumshirn <jthumshirn@xxxxxxx> Cc: Sajjan, Vikas C <vikas.cha.sajjan@xxxxxxx>; Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>; linux-nvdimm@xxxxxxxxxxxx; Linux ACPI <linux-acpi@xxxxxxxxxxxxxxx>; Knippers, Linda <linda.knippers@xxxxxxx> Subject: Re: [PATCH] dax: use devm_add_action_or_reset() Thanks, applied. Thank you, Dan. On Mon, Jul 4, 2016 at 11:59 PM, Johannes Thumshirn <jthumshirn@xxxxxxx> wrote: > On Tue, Jul 05, 2016 at 11:20:07AM +0530, Vikas C Sajjan wrote: >> If devm_add_action() fails, we are explicitly calling the cleanup to >> free the resources allocated. Use the helper >> devm_add_action_or_reset() and return directly in case of error, >> since the cleanup function has been already called by the helper if there was any error. >> >> Reported-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> >> Signed-off-by: Vikas C Sajjan <vikas.cha.sajjan@xxxxxxx> > > Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> > > -- > Johannes Thumshirn Storage > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG > Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D > 2D76 0850 ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
