On Tue, Jul 05, 2016 at 04:30:28PM +0100, Tony Makkiel wrote: > +#ifdef CONFIG_ACPI > +static const struct acpi_device_id lp3952_acpi_match[] = { > + {LP3952_ACPI_NAME, 0}, I would just drop the silly macro and use { "TXNW3952" }, instead. > + {} > +}; > + > +MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match); > +#endif > + > +static struct i2c_driver lp3952_i2c_driver = { > + .driver = { > + .name = LP3952_NAME, > + .acpi_match_table = ACPI_PTR(lp3952_acpi_match), > + }, > + .probe = lp3952_probe, > + .remove = lp3952_remove, > + .id_table = lp3952_id, > +}; > + Anyway ACPI parts look good enough, Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html