On 6/23/2016 8:45 AM, Mike Galbraith wrote:
Commit 920de6ebfab8 apparently exposed a latent bug, doorbell.access_width
is initialized to 64, but per Lv Zheng, it should be 4, and indeed, making
that change does bring pcc-cpufreq back to life.
Suggested-by: Lv Zheng <lv.zheng@xxxxxxxxx>
Signed-off-by: Mike Galbraith <umgwanakikbuti@xxxxxxxxx>
---
drivers/cpufreq/pcc-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/cpufreq/pcc-cpufreq.c
+++ b/drivers/cpufreq/pcc-cpufreq.c
@@ -487,7 +487,7 @@ static int __init pcc_cpufreq_probe(void
doorbell.space_id = reg_resource->space_id;
doorbell.bit_width = reg_resource->bit_width;
doorbell.bit_offset = reg_resource->bit_offset;
- doorbell.access_width = 64;
+ doorbell.access_width = 4;
doorbell.address = reg_resource->address;
pr_debug("probe: doorbell: space_id is %d, bit_width is %d, "
OK, I picked this up from the LKML patchwork (will push to Linus
tomorrow), but next time please CC patches related to ACPI to linux-acpi
and PM patches to linux-pm (so this one should have gone to both,
ideally). They are much easier to handle/review then and more people
are likely to look at them too.
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
