Re: [PATCH v2] ACPI: Support for platform initiated graceful shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, June 15, 2016 02:05:05 PM Prakash, Prashanth wrote:
> Hi Rafael,
> 
> Any inputs on this patch?

Does it actually work?

It looks like sybus_evaluate_ost() schedules itself with a delay in an
endless loop and the poweroff will happen anyway without waiting.

I guess the idea is that acpi_sybus_notify() will schedule a delayed work
doing the sybus_evaluate_ost() and that will do the orderly_poweroff() thing,
but that's not what the patch is doing.

That "sybus" naming looks sort of lame BTW.  What's wrong with using "sb"
instead?

Besides actypes.h is an ACPICA file and patches updating it have to go via
upstream ACPICA.

And one more thing, if you checked acpi_get_handle() for "\\_SB" once,
it will succeed every time going forward.  No need to check again.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux