On Fri, Apr 29, 2016 at 10:21:29PM +0200, Rafael J. Wysocki wrote:
> On Thu, Apr 28, 2016 at 12:23 PM, Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> > Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
> > PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
> >
> > Device (SBUS)
> > {
> > OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
> > Field (SMBI, ByteAcc, NoLock, Preserve)
> > {
> > HSTS, 8,
> > Offset (0x02),
> > HCON, 8,
> > HCOM, 8,
> > TXSA, 8,
> > DAT0, 8,
> > DAT1, 8,
> > HBDR, 8,
> > PECR, 8,
> > RXSA, 8,
> > SDAT, 16
> > }
> >
> > There are also bunch of ASL methods that that the BIOS can use to access
> > these fields. Most of the systems in question ASL methods accessing the
> > SMBI OpRegion are never used.
> >
> > Now, because of this SMBI OpRegion many systems fail to load the SMBus
> > driver with an error looking like one below:
> >
> > ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
> > conflicts with OpRegion 0x0000000000003040-0x000000000000304F
> > (\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
> > ACPI: If an ACPI driver is available for this device, you should use
> > it instead of the native driver
> >
> > The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
> > the SMBus driver.
> >
> > It turns out that we can install a custom SystemIO address space handler
> > for the SMBus device to intercept all accesses through that OpRegion. This
> > allows us to share the PCI BAR with the ASL code if it for some reason is
> > using it. We do not expect that this OpRegion handler will ever be called
> > but if it is we print a warning and execute the read/write operation under
> > a lock which prevents ASL and OS from messing each other.
> >
> > Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Thanks!
> If it addresses any public BZ bugs, it would be good to add Link: tags
> for those and maybe Reported-by: for the reporters?
Good point. I can add those.
However, after reading ACPI 6.1 spec again, I'm having second thoughts
about this patch. See my other email to Andy on this thread.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
