Hi > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@xxxxxxxxxxxxx] > Sent: Thursday, April 28, 2016 5:25 AM > To: Chen, Yu C; Zheng, Lv > Cc: Lv Zheng; linux-kernel@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; > Wysocki, Rafael J; Brown, Len > Subject: Re: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support > > On Wednesday, April 27, 2016 09:45:21 AM Chen, Yu C wrote: > > Hi Lv, > > > > > -----Original Message----- > > > From: Zheng, Lv > > > Sent: Wednesday, April 27, 2016 4:55 PM > > > To: Wysocki, Rafael J; Rafael J. Wysocki; Brown, Len > > > Cc: Zheng, Lv; Lv Zheng; linux-kernel@xxxxxxxxxxxxxxx; linux- > > > acpi@xxxxxxxxxxxxxxx; Chen, Yu C > > > Subject: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support > > > > > > From: Chen Yu <yu.c.chen@xxxxxxxxx> > > > > > > The following commit always reports positive value when Apple > > > hardware queries _OSI("Darwin"): > > > Commit: 7bc5a2bad0b8d9d1ac9f7b8b33150e4ddf197334 > > > Subject: ACPI: Support _OSI("Darwin") correctly However since this > > > implementation places the judgement in runtime, it breaks > > > acpi_osi=!Darwin and cannot return unsupported for _OSI("WinXXX") > > > invoked before invoking _OSI("Darwin"). > > > > > > This patch fixes the issues by reverting the wrong support and > > > implementing the default behavior of _OSI("Darwin")/_OSI("WinXXX") > > > on Apple hardware via DMI matching. > > > > > > Fixes: 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.18+ > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=92111 > > > Reported-by: Lukas Wunner <lukas@xxxxxxxxx> > > > Signed-off-by: Chen Yu <yu.c.chen@xxxxxxxxx> > > > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx> > > The vendor id should be 'Apple Inc.' and 'Apple Computer, Inc.' instead. > > If this is the only problem with this patch, I can fix it up. No need to resend. Yes, this is the only problem, please help fix it, thanks! > > Thanks, > Rafael ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
