On Mon, Apr 11, 2016 at 09:31:54AM +0200, Sebastian Andrzej Siewior wrote: > On 04/09/2016 02:22 AM, Luis R. Rodriguez wrote: > > What seems a bit odd is CE4100 leaves RTC enabled, can someone > > confirm if indeed it really needs it, or can it also disable it > > as with Xen, lguest, and Intel MID ? > > So what you do with "x86_platform.legacy.rtc" is to skip > add_rtc_cmos(). Yeap. > For ce4100 I added of_have_populated_dt() to skip the probe. Ah look at that.. x86 using device tree. Wasn't aware. > If you plan to add this to CE4100 you could remove the > "of_have_populated_dt()". It was meant to skip the RTC probe on all OF > platforms but as of now, CE4100 is the only. Indeed, this would clean up the add_rtc_cmos() path more and make the semantics required for this a platform specific quirk which can instead more easily be set by the platform on the generic: x86_early_init_platform_quirks() Will go a head and remove this hack as part of the CE4100 patch, and also add CE4100 to the list of subarchs that need the RTC quirk. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
