On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote: > > Currently it just complains if something goes wrong. The GPIO driver > > itself can still work just fine (including interrupts). > > > > I'm fine to change it to return an error code. > Agree, if add a error code for acpi_gpiochip_request_interrupts(), it looks more pretty. > > However, this function is common for other part, maybe cause any other effects if I > do this change, did you think so? I'm thinking what the callers are going to do with the error code. Basically it means that we were not able to attach and configure ACPI event GPIOs. It does not prevent GPIO drivers from functioning so they probably just print out some warning message and continue probing, and we already warn in acpi_gpiochip_request_interrupts() if something fails. Unless Linus W insists, let's just keep it as is for now :) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
