On Thu, Apr 07, 2016 at 02:25:38PM +0300, Andy Shevchenko wrote: > On Wed, 2016-04-06 at 17:06 -0700, Luis R. Rodriguez wrote: > > Although hardware_subarch has been in place since the x86 boot > > protocol 2.07 it hasn't been used much. Enumerate current possible > > values to avoid misuses and help with semantics later at boot > > time should this be used further. > > > > These enums should only ever be used by architecture x86 code, > > and all that code should be well contained and compartamentalized, > > clarify that as well. > > Nitpick: > > > + * @X86_SUBARCH_PC: Should be used if the hardware is enumerable > > using standard > > + * PC mechanisms (PCI, ACPI) and doesn't need a special boot > > flow. > > + * @X86_SUBARCH_LGUEST: Used for x86 hypervisor demo, lguest > > + * @X86_SUBARCH_XEN: Used for Xen guest types which follow the PV > > boot path, > > + * which start at asm startup_xen() entry point and later > > jump to the C > > + * xen_start_kernel() entry point. > > + * @X86_SUBARCH_INTEL_MID: Used for Intel MID (Mobile Internet > > Device) platform > > + * systems which do not have the PCI legacy interfaces. > > + * @X86_SUBARCH_CE4100: Used for Intel CE media processor (CE4100) > > SOC for > > I think 'SoC' (without quotes) will be better. Amended, since I think I'll need a re-spin and since we may need to take care of the dom0 Vs domU semantics I'll also make some changes to include X86_SUBARCH_XEN documentation to annotate that PV guests can be of domU or dom0 type... Luis -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
