On Tue, Dec 29, 2015, at 10:27, Hans de Goede wrote:
> So it only disables hotkey press reporting, not to the thinkpad_acpi
> backlight handling code, that still is using
> acpi_video_get_backlight_type() :
...
> This should not matter though, as said this new function is only used to
> suppress
> the reporting of key-presses. I realize that doing so will also cause
> tpacpi_driver_event() to get called on brightness hotkey presses, but
> that has:
>
> if (ibm_backlight_device) {
> switch (hkey_event) {
> case TP_HKEY_EV_BRGHT_UP:
> case TP_HKEY_EV_BRGHT_DOWN:
> tpacpi_brightness_notify_change();
> }
> }
>
> And the creating of ibm_backlight_device is still protected by
>
> if (acpi_video_get_backlight_type() != acpi_backlight_vendor) return 1;
Indeed. I have no objections to the patch, then.
Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
