Re: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29.10.2015 15:57, Sinan Kaya wrote:


On 10/28/2015 4:36 PM, Sinan Kaya wrote:
2. The second problem is about the PCIe resources.

pci_0000:01:00.0:_can't_enable_device:_BAR_0_[mem_0x80100100000-0x80100101fff_64bit]_not_claimed


pci 0000:01:00.0: Can't enable PCI device, BIOS handoff failed.
pci 0000:00:00.0: BAR 14: assigned [mem 0x80100100000-0x801003fffff]
pci 0000:00:00.0: BAR 13: no space for [io  size 0x1000]
pci 0000:00:00.0: BAR 13: failed to assign [io  size 0x1000]
pci 0000:00:00.0: BAR 13: no space for [io  size 0x1000]
pci 0000:00:00.0: BAR 13: failed to assign [io  size 0x1000]
pci 0000:01:00.0: BAR 0: assigned [mem 0x80100100000-0x80100101fff 64bit]

For some reason, the kernel is unable to assign resources.

I appreciate any pointers you might give.

Tomasz,
I debugged this part of the problem yesterday night.

I have one set up with 4.2 kernel and Mark Salter's original ACPI PCIE
patch. His patchwork works fine with our ACPI table.

This is what IO resource looks like in our table. PCI IO is supported
using the ACPI translation attribute on ARM systems.

QWORDIO(            // produced resource
     ResourceProducer,    // bit 0 of general flags is 0
     MinFixed,        // Range is fixed
     MaxFixed,        // Range is fixed
     PosDecode,
     EntireRange,
     0x0000,            // Granularity
     0x1000,            // Min,
     0xFFFF,            // Max
     0x8FFFFFEF000,        // Translation
     0xF000,            // Range Length
     ,, PI00
  )

It looks like you are missing the translation support for the IO
aperture and Mark Salter's patch has this support.

Yours is missing in pci_acpi_root_prepare_resources function here.
Mark's patch uses the offset argument to reorganize the resource.


+            resource_size_t length = res->end - res->start;
+
+            err = pci_register_io_range(res->start, length);
+            if (err) {
+                resource_list_destroy_entry(entry);
+                continue;
+            }
+
+            port = pci_address_to_pio(res->start);
+            if (port == (unsigned long)-1) {
+                resource_list_destroy_entry(entry);
+                continue;
+            }
+
+            res->start = port;
+            res->end = res->start + length - 1;
+
+            if (pci_remap_iospace(res, res->start) < 0)
+                resource_list_destroy_entry(entry);



Thanks for the heads up, working on it.

Regards,
Tomasz


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux