RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +           ((param2 & PAGE_MASK) != PAGE_MASK))
>                return -EINVAL;
>
> The 3rd condition check makes sure that the param2 mask is the page size or less.  So, I
> think we are OK on this.

Oops. The original was even on the screen as part of the diff (which I signed off on just two years ago).

I'd be happier if you made it the 1st condition though, so we skip calling region_intersects_*() with
a nonsense "size" argument.

-Tony

��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux