On Thu, Aug 27, 2015 at 08:09:55PM +0530, Kasagar, Srinidhi wrote:
> On Mon, Aug 24, 2015 at 12:44:55PM +0300, Mika Westerberg wrote:
> > On Mon, Aug 24, 2015 at 10:39:21PM +0530, Kasagar, Srinidhi wrote:
> > > Ok, then we have two options:
> > >
> > > Let's drop LPSS_NO_D3_DELAY for BYT and duplicate the common devices which
> > > are shared between Braswell and BYT & keep LPSS_NO_D3_DELAY only for BSW.
> >
> > That sounds the safest option for now.
> >
> > > OR
> > > Use the cpu id to detect the platform which I believe not a good idea..
> > >
> > > Because of few devices, I do not think it make sense to compromise on
> > > the significant reduction in the resume delay.
> >
> > I agree.
>
> Refreshed the patch (below) affecting BSW platform alone.
>
> But this does not solve your earlier concern on Broadwell which
> shares the same acpi ids..
It does not share IDs:
/* Braswell LPSS devices */
{ "80862288", LPSS_ADDR(byt_pwm_dev_desc) },
{ "8086228A", LPSS_ADDR(byt_uart_dev_desc) },
{ "8086228E", LPSS_ADDR(bsw_spi_dev_desc) },
{ "808622C1", LPSS_ADDR(byt_i2c_dev_desc) },
/* The following are Broadwell LPSS IDs _not_ Braswell */
{ "INT3430", LPSS_ADDR(lpt_dev_desc) },
{ "INT3431", LPSS_ADDR(lpt_dev_desc) },
{ "INT3432", LPSS_ADDR(lpt_i2c_dev_desc) },
{ "INT3433", LPSS_ADDR(lpt_i2c_dev_desc) },
{ "INT3434", LPSS_ADDR(lpt_uart_dev_desc) },
{ "INT3435", LPSS_ADDR(lpt_uart_dev_desc) },
{ "INT3436", LPSS_ADDR(lpt_sdio_dev_desc) },
{ "INT3437", },
So please make the patch touch only the four 808622* devices above
unless you have tested this on Broadwell as well.
Otherwise the patch looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
