Add a comment clarifying the need for the __ref annotation of acpi_os_unmap_iomem(). It's safe, however, as acpi_early_init() will set acpi_gbl_permanent_mmap to 1, disabling the problematic branch. Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx> Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> --- drivers/acpi/osl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 3b8963f21b36..7e85fb84e536 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -442,6 +442,9 @@ static void acpi_os_map_cleanup(struct acpi_ioremap *map) } } +/* The __ref annotation is needed as during init we may call out to + * __acpi_unmap_table() which is an __init annotated function. + */ void __ref acpi_os_unmap_iomem(void __iomem *virt, acpi_size size) { struct acpi_ioremap *map; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html