On 16 June 2015 at 00:49, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: > On Saturday, June 13, 2015 02:26:48 PM Mathias Krause wrote: >> this series constifies a few variables in the ACPI code that are read >> only and therefore can be const. The main goal is to constify all users >> of struct acpi_device_id, but while digging through the code I found a >> few other places that could be improved too (constifying other variables >> in patches 1, 2, 4 and 9 as adding __init annotations where sensible in >> patch 7 or dropping bogus annotations in patch 3). > > I've queued up the series for 4.2 except for patches [3/12] and [4/12]. > > My recollection of the __refdata in the processor driver is that it was needed > for some obscure reason, so that one requires some more thorough code inspection I guess it was needed for the __cpuinit annotation (see e.g. v3.11-rc1:drivers/acpi/acpi_processor.c). But that one was dropped during the development of v3.11 in commit fe7bf106ebc2 "acpi: delete __cpuinit usage from all acpi files", obsoleting the need for the __refdata annotation. Should I update the patch description and resend a v2? > and the [4/12] gets in the way of something (I'll apply it later when I'm done > with that other thing). Okay, thanks. Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
