Here are the corrected strings: /* NVDIMM - NFIT table */ #define UUID_VOLATILE_MEMORY "7305944f-fdda-44e3-b16c-3f22d252e5d0" #define UUID_PERSISTENT_MEMORY "66f0d379-b4f3-4074-ac43-0d3318b78cdb" #define UUID_CONTROL_REGION "92f701f6-13b4-405d-910b-299367e8234c" #define UUID_DATA_REGION "91af0530-5d86-470e-a6b0-0a2db9408249" #define UUID_VOLATILE_VIRTUAL_DISK "77ab535a-45fc-624b-5560-f7b281d1f96e" #define UUID_VOLATILE_VIRTUAL_CD "3d5abd30-4175-87ce-6d64-d2ade523c4bb" #define UUID_PERSISTENT_VIRTUAL_DISK "5cea02c9-4d07-69d3-269f-4496fbe096f9" #define UUID_PERSISTENT_VIRTUAL_CD "08018188-42cd-bb48-100f-5387d53ded3d" > -----Original Message----- > From: Toshi Kani [mailto:toshi.kani@xxxxxx] > Sent: Friday, May 22, 2015 8:21 AM > To: Moore, Robert > Cc: Williams, Dan J; Linda Knippers; Jens Axboe; linux- > nvdimm@xxxxxxxxxxxx; Neil Brown; Greg KH; Wysocki, Rafael J; linux- > kernel@xxxxxxxxxxxxxxx; Linux ACPI; Ingo Molnar; Zheng, Lv; Christoph > Hellwig > Subject: Re: [PATCH v3 02/21] libnd, nfit: initial libnd infrastructure > and NFIT support > > On Fri, 2015-05-22 at 14:58 +0000, Moore, Robert wrote: > > It looks to me that you are correct and I screwed up when I made those > strings. > > The odd thing is that we had discussed this whole issue internally for > > a few days > > -- then I went ahead and messed up the strings. I think my brain was > > going around in circles. > > Yes, endianness is always fun... :-) > > > Anyway, here is the latest info, please have a look: > > > > > > Below is the GUID for volatile memory region directly from the ACPI > spec: > > > > > > { 0x7305944F, 0xFDDA, 0x44E3, 0xB1, 0x6C, 0x3F, 0x22, 0xD2, 0x52, > > 0xE5, 0xD0 } > > > > Here is an example of ToUUID using a corrected version of the GUID > string. Note that the ordering of the string is identical to the version > in the ACPI spec: > > > > 11: Name (UUID, ToUUID ("7305944F-FDDA-44E3-B16C- > 3F22D252E5D0")) > > > > > > Here is the AML output of the ToUUID macro. Note that the first three > fields are reversed, the rest of the string is left as-is (as per the > ToUUID definition): > > > > 00000024: 08 55 55 49 44 ......... ".UUID" > > 00000029: 11 13 0A 10 4F 94 05 73 "....O..s" > > 00000031: DA FD E3 44 B1 6C 3F 22 "...D.l?"" > > 00000039: D2 52 E5 D0 ............ ".R.." > > > > This is the important part: > > > > 4F 94 05 73 "....O..s" > > 00000031: DA FD E3 44 B1 6C 3F 22 "...D.l?"" > > 00000039: D2 52 E5 D0 > > > > > > I believe that this is correct. > > Looks good! > > Thanks, > -Toshi > ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
