On Fri, May 15, 2015 at 1:25 PM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote: > Dan Williams <dan.j.williams@xxxxxxxxx> writes: > >> +config NFIT_TEST >> + tristate "NFIT TEST: Manufactured NFIT for interface testing" >> + depends on DMA_CMA >> + depends on LIBND=m >> + depends on ND_ACPI >> + depends on m >> + help >> + For development purposes register a manufactured >> + NFIT table to verify the resulting device model topology. >> + Note, this module arranges for ioremap_cache() to be >> + overridden locally to allow simulation of system-memory as an >> + io-memory-resource. >> + >> + Note, this test expects to be able to find at least 256MB of >> + CMA space (CONFIG_CMA_SIZE_MBYTES, cma=) or it will fail to >> + load. >> + >> + Say N unless you are doing development of the 'nd' subsystem. >> + > > Too many TLAs. I'm guessing CMA means Conventional Memory Area to you. > To me it means contiguous memory allocator. I means Contiguous Memory Allocator to me too. > Anyway, please define > acronyms when you use them, especially in help text. The help text also > doesn't really explain where it will find this memory. Would it be > possible to provide more direction there? I didn't think I needed to define CMA in the context of Kconfig, but I'll replace it with CONFIG_DMA_CMA to be more clear. > I don't have any useful commentary on the patch itself. I do wonder if > you shouldn't move this to the end, as it's hardly an integral part of > the patch set. True. The patches are currently in "development order" in that I created the test infrastructure before the rest of the implementation. But, I agree it makes sense to move this to the end for the next posting. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
