On Tue, 2015-04-21 at 15:05 -0700, Dan Williams wrote:
> On Tue, Apr 21, 2015 at 2:20 PM, Toshi Kani <toshi.kani@xxxxxx> wrote:
:
> >> +static int nd_acpi_add_dimm(struct nfit_bus_descriptor *nfit_desc,
> >> + struct nd_dimm *nd_dimm)
> >> +{
> >> + struct acpi_nfit *nfit = to_acpi_nfit(nfit_desc);
> >> + u32 nfit_handle = to_nfit_handle(nd_dimm);
> >> + struct device *dev = &nfit->dev->dev;
> >> + struct acpi_device *acpi_dimm;
> >> + unsigned long dsm_mask = 0;
> >> + u8 *uuid = nd_acpi_dimm_uuid();
> >> + unsigned long long sta;
> >> + int i, rc = -ENODEV;
> >> + acpi_status status;
> >> +
> >> + acpi_dimm = acpi_find_child_device(nfit->dev, nfit_handle, false);
> >> + if (!acpi_dimm) {
> >> + dev_err(dev, "no ACPI.NFIT device with _ADR %#x, disabling...\n",
> >> + nfit_handle);
> >> + return -ENODEV;
> >> + }
> >> +
> >> + status = acpi_evaluate_integer(acpi_dimm->handle, "_STA", NULL, &sta);
> >> + if (status == AE_NOT_FOUND)
> >> + dev_err(dev, "%s missing _STA, disabling...\n",
> >> + dev_name(&acpi_dimm->dev));
> >
> > I do not think it is correct to set a DIMM _ADR object disabled when it
> > has no _STA. ACPI 6.0 spec states the followings:
> >
> > - Section 6.3.7 _STA, "If a device object describes a device that is
> > not on an enumerable bus and the device object does not have an _STA
> > object, then OSPM assumes that the device is present, enabled, shown in
> > the UI, and functioning."
>
> Ok, I'll take a look.
Great!
> [..]
> > So, in this case, it should set the DIMM object enabled or look up the
> > NFIT table to check the presence.
>
> At this point we've already determined that a dimm device is present
> because nd_acpi_add_dimm() is called for each dimm found in the NFIT.
> Does that count as "enumerable" and require an _STA?
I think it means that if a bus is enumerable, then it needs to enumerate
the bus to check the status, instead of assuming it present. In other
words, _STA is required for representing non-present status on a
non-enumerable bus.
In any case, we've already enumerated the NFIT table before this point,
so there is no reason to handle the non-_STA case as disabled.
Thanks,
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
