> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index c458458..4ea6d27 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -15,6 +15,108 @@
> > #include <linux/acpi.h>
> > #include <linux/of.h>
> >
> > +static struct dev_gen_prop *dev_prop_get(struct device *dev, const char *name)
> > +{
> > + struct dev_gen_prop *prop;
> > +
> > + if (!dev->gen_prop)
> > + return NULL;
> > +
> > + for (prop = dev->gen_prop; prop->name; prop++)
> > + if (!strcmp(name, prop->name))
> > + return prop;
> > + return NULL;
> > +}
> > +
> > +static int dev_prop_copy_array_u8(u8 *src, u8 *val, size_t nval)
> > +{
> > + int i;
> > +
> > + for (i = 0; i < nval; i++)
> > + val[i] = src[i];
>
> Use memcpy() perhaps? And below too? And then you may not need these
> helpers any more.
OK.
<snip>
> > @@ -780,6 +782,7 @@ struct device {
> >
> > struct device_node *of_node; /* associated device tree node */
> > struct acpi_dev_node acpi_node; /* associated ACPI device node */
> > + struct dev_gen_prop *gen_prop; /* generic device property */
>
> That doesn't seem to go in the right direction to be honest.
>
> Actually, having introduced struct fwnode_handle, we should perhaps try to
> replace both of_node and acpi_node with a single struct fwnode_handle pointer
> and then add a new fwnode_type for the "pdata" stuff.
>
> If you don't want to deal with of_node, which I can understand easily, it
> may be worth trying with acpi_node alone at this point and once you have
> the fwnode_handle pointer, you might use it for both ACPI and "pdata"?
It sounds like a better Idea to me too.
Thanks,
--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
