On 2015/2/23 20:45, Andy Shevchenko wrote: > On Tue, 2015-01-20 at 23:49 +0200, Andy Shevchenko wrote: >> This is the reworked patch series which had been sent earlier [1] to support >> Intel CherryTrail SoC. >> >> The patches were tested on both BayTrail and CherryTrail SoCs. >> >> [1] https://patchwork.kernel.org/patch/5235891/ > > Aubrey, is everything is clear for you now? Can I send v3 with your > Ack's? > The patches overall look good to me, except a few minor comments need to be addressed in the last conversation. For example, I think we don't need patch 1/4 if we won't use dev_print. some other changes might be necessary only if they makes code cleaner and works better. Certainly, it would be better if other x86 maintainers can take a look at these patches. Thanks, -Aubrey >> >> Changes to v1: >> - rebased on top of recent pmc_atom changes >> - cleaned up, reqorked and split to few smaller patches >> >> Andy Shevchenko (4): >> x86: pmc_atom: save struct device pointer in pmc >> x86: pmc_atom: print index of device in loop >> x86: pmc_atom: supply register mappings via pmc object >> PMC driver: Add Cherrytrail PMC interface >> >> arch/x86/include/asm/pmc_atom.h | 25 ++++ >> arch/x86/kernel/pmc_atom.c | 270 +++++++++++++++++++++++++--------------- >> 2 files changed, 198 insertions(+), 97 deletions(-) >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
