On Wednesday, February 25, 2015 03:01:08 PM Scot Doyle wrote: > On Wed, 25 Feb 2015, Zheng, Lv wrote: > ... > > > I was using "+++++"/"#####"/"*****" to filter different EC log entries which makes debugging easier. > > > And, if we changed this from pr_info into pr_debug, then we will have nothing in the suspend/resume logs for the EC device. > > > While there are plenty of such log entries for each of other devices. > > > So I really doubt what's the meaning of such a change. > > > Could it improve anything or just make debugging more difficult for developers? > > > > IMO, it's better to introduce such kind of code in the head of ec.c: > > > > #ifdef DEBUG_FILTER > > #define EC_LOG_DEV "+++++" > > #define EC_LOG_CMD "*****" > > #define EC_LOG_EVT "#####" > > ... > > #else > > #define EC_LOG_DEV > > #define EC_LOG_CMD > > #define EC_LOG_EVT > > #endif > > > > And wrap the pr_info, pr_debug using filter enabled new macros - ec_info, ec_debug so that we won't see the filters in the normal dmesg output and the filters are still available for the developers. > > > > Thanks and best regards > > -Lv > > I agree, would you be willing to submit it? Yes, sounds good to me too! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
