On Mon, Feb 16, 2015 at 2:26 AM, Jarkko Nikula
<jarkko.nikula@xxxxxxxxxxxxxxx> wrote:
> Revert commit b893e80e3147 ("ACPI / LPSS: Remove non-existing clock control
> from Intel Lynxpoint I2C") because it causes touchpad to not load on Dell
> XPS13.
>
> Regression is a clear indication that not only some early prototype version
> of Lynxpoint I2C but also newer versions can be doing clock gating even
> documentation does not state it.
>
> Therefore it is best to revert since this clock gating haven't caused known
> issues on those Lynxpoint version which don't do clock gating.
>
> Reported-by: Chris Rorvick <chris@xxxxxxxxxxx>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> ---
> For v3.20.
> ---
> drivers/acpi/acpi_lpss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 02e835f3cf8a..fa0e3d61e5e7 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -125,7 +125,7 @@ static struct lpss_device_desc lpt_dev_desc = {
> };
>
> static struct lpss_device_desc lpt_i2c_dev_desc = {
> - .flags = LPSS_CLK | LPSS_LTR,
> + .flags = LPSS_CLK | LPSS_CLK_GATE | LPSS_LTR,
> .prv_offset = 0x800,
> };
Tested-by: Chris Rorvick <chris@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
