On Wednesday, December 24, 2014 11:16:48 PM Eugene Korenevsky wrote:
> A trivial fix. No need to check `p` for NULL.
> `resource` pointer is valid therefore `p` is also valid.
>
> Signed-off-by: Eugene Korenevsky <ekorenevsky@xxxxxxxxx>
Queued up for 3.20, thanks!
> ---
> drivers/acpi/pci_link.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index cfd7581..6379186 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -111,7 +111,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,
> case ACPI_RESOURCE_TYPE_IRQ:
> {
> struct acpi_resource_irq *p = &resource->data.irq;
> - if (!p || !p->interrupt_count) {
> + if (!p->interrupt_count) {
> ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> "Blank _PRS IRQ resource\n"));
> return AE_OK;
> @@ -137,7 +137,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,
> {
> struct acpi_resource_extended_irq *p =
> &resource->data.extended_irq;
> - if (!p || !p->interrupt_count) {
> + if (!p->interrupt_count) {
> printk(KERN_WARNING PREFIX
> "Blank _PRS EXT IRQ resource\n");
> return AE_OK;
> @@ -198,7 +198,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,
> case ACPI_RESOURCE_TYPE_IRQ:
> {
> struct acpi_resource_irq *p = &resource->data.irq;
> - if (!p || !p->interrupt_count) {
> + if (!p->interrupt_count) {
> /*
> * IRQ descriptors may have no IRQ# bits set,
> * particularly those those w/ _STA disabled
> @@ -214,7 +214,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,
> {
> struct acpi_resource_extended_irq *p =
> &resource->data.extended_irq;
> - if (!p || !p->interrupt_count) {
> + if (!p->interrupt_count) {
> /*
> * extended IRQ descriptors must
> * return at least 1 IRQ
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
