Re: [PATCH v1] ACPI / Fan: Use bus id for non PNP0C0B (Fan) device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-12-10 at 22:53 +0100, Rafael J. Wysocki wrote: 
> On Tuesday, December 09, 2014 04:15:40 PM Srinivas Pandruvada wrote:
> > The _ART (Active Cooling Relationship Table), specifies relationship
> > among heat generating sources to a target active cooling device like
> > fan. The _ART table refers to actual bus id name for specifying relationship.
> > Naming "Fan" is not enough as name in the _ART table can change on every
> > platform, to establish relationship for user space thermal controllers.
> > 
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> 
> I can apply this or do you have any thermal material depending on it?
This patch can go independently as no thermal patches depends on this.
Thanks,
Srinivas 
> 
> > ---
> >  drivers/acpi/fan.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
> > index caf9b76..7a36f02 100644
> > --- a/drivers/acpi/fan.c
> > +++ b/drivers/acpi/fan.c
> > @@ -325,6 +325,7 @@ static int acpi_fan_probe(struct platform_device *pdev)
> >  	struct thermal_cooling_device *cdev;
> >  	struct acpi_fan *fan;
> >  	struct acpi_device *device = ACPI_COMPANION(&pdev->dev);
> > +	char *name;
> >  
> >  	fan = devm_kzalloc(&pdev->dev, sizeof(*fan), GFP_KERNEL);
> >  	if (!fan) {
> > @@ -346,7 +347,12 @@ static int acpi_fan_probe(struct platform_device *pdev)
> >  		}
> >  	}
> >  
> > -	cdev = thermal_cooling_device_register("Fan", device,
> > +	if (!strncmp(pdev->name, "PNP0C0B", strlen("PNP0C0B")))
> > +		name = "Fan";
> > +	else
> > +		name = acpi_device_bid(device);
> > +
> > +	cdev = thermal_cooling_device_register(name, device,
> >  						&fan_cooling_ops);
> >  	if (IS_ERR(cdev)) {
> >  		result = PTR_ERR(cdev);
> > 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux