On Thu, Oct 30, 2014 at 12:57 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > On Thu, Oct 30, 2014 at 10:09 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >>> Fixing: commit 6cd33649fa83 ("PCI: Add pci_configure_device() during enumeration") >> >> Thanks for including this, but why not use the same format everybody else >> does: >> >> Fixes: 6cd33649fa83 ("PCI: Add pci_configure_device() during enumeration") > > will do that later. Is that formalized ? I don't know that it's formalized, but it seems to be a common convention, and using "Fixing: commit" instead of "Fixes:" doesn't seem to add value. I guess I must spend more time reading git logs than most people :) > checkpatch.pl only need 12 commit code, and (" ..") format. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html