On Monday, October 06, 2014 04:38:15 PM Thomas Richter wrote: > Dear experts, > > > > following the bug report on bugzilla > > > > https://bugzilla.kernel.org/show_bug.cgi?id=84381 > > > > the extra buttons (ACPI-driven buttons) on the R31 laptop do not work > > since kernel 3.17.0. > > Kernel 3.16.x worked fine. The same problem (or at least a very > > similar problem) exists > > on the Fujitsu-S6010 laptop. > > > > After debugging for a while, the culprit seems to be in > > arch/x86/kernel/acpi/boot.c, in specific > > in acpi_gsi_to_irq(). The following changes fix this problem for at > > least the S6010: > > > > static unsigned int gsi_to_irq(unsigned int gsi) > > { > > unsigned int irq = gsi + NR_IRQS_LEGACY; > > unsigned int i; > > > > for (i = 0; i< NR_IRQS_LEGACY; i++) { > > if (isa_irq_to_gsi[i] == gsi) { > > return i; > > } > > } > > > > /* Provide an identity mapping of gsi == irq > > * except on truly weird platforms that have > > * non isa irqs in the first 16 gsis. > > */ > > if (gsi>= NR_IRQS_LEGACY) > > irq = gsi; > > else > > irq = gsi_top + gsi; > > > > return irq; > > } > > /* THOR: Experimental end */ > > > > int acpi_gsi_to_irq(u32 gsi, unsigned int *irqp) > > { > > int irq = mp_map_gsi_to_irq(gsi, IOAPIC_MAP_ALLOC | > > IOAPIC_MAP_CHECK); > > > > if (irq>= 0) { > > *irqp = irq; > > return 0; > > } > > > > /* THOR: Experimental start */ > > irq = gsi_to_irq(gsi); > > if (irq>= 0) { > > *irqp = irq; > > return 0; > > } > > /* THOR Experimental end */ > > > > return -1; > > } > > > > Whether this works on the R31 is yet to be determined. > > > The above patch has now also been tested on the IBM R31, and yes, it > also fixes the system keys there: Thinklight, volume up & down and > various other system-driven key-combinations now work again. > > Could you please pick this patch up or comment on better alternatives? And can you please actually post a patch? The above is just a piece of C code entirely out of context. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
