On Tuesday, September 23, 2014 06:29:17 PM Mika Westerberg wrote:
> On Tue, Sep 23, 2014 at 05:32:02PM +0200, Rafael J. Wysocki wrote:
> > On Tuesday, September 23, 2014 01:27:28 PM Mika Westerberg wrote:
> > > On Tue, Sep 23, 2014 at 10:35:54AM +0800, Lv Zheng wrote:
> > > > From: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > > >
> > > > Fix code when the operation region callback is for an gpio, which
> > > > is not at index 0 and for partial pins in a GPIO definition.
> > > > For example:
> > > > Name (GMOD, ResourceTemplate ()
> > > > {
> > > > //3 Outputs that define the Power mode of the device
> > > > GpioIo (Exclusive, PullDown, , , , "\\_SB.GPI2") {10, 11, 12}
> > > > })
> > > > }
> > > >
> > > > If opregion callback calls is for:
> > > > - Set pin 10, then address = 0 and bit length = 1
> > > > - Set pin 11, then address = 1 and bit length = 1
> > > > - Set for both pin 11 and pin 12, then address = 1, bit length = 2
> > > >
> > > > This change requires updated ACPICA gpio operation handler code to
> > > > send the pin index and bit length.
> > > >
> > > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > > > Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > >
> > > Adding the GPIO maintainers since we need their ACK to get this merged
> > > through ACPI tree.
> >
> > Actually, it would be good to say that the ACPICA change mentioned in the
> > changelog above is made by patch [1/2] in this series.
> >
> > Linus, Alexandre, please let us know if you need the whole series to be
> > resent for context. This is quite urgent, as we need that fixed in 3.18,
> > because there are systems out there where it doesn't work already.
> >
> > Mika, Srinivas, I suppose that we need this in -stable? Which one if so?
>
> The GPIO operation region support was introduced with commit
> 473ed7be0da04 (gpio / ACPI: Add support for ACPI GPIO operation
> regions):
>
> % git describe 473ed7be0da041275d57ab0bde1c21a6f23e637f
> v3.14-rc6-61-g473ed7be0da0
>
> So if I understand the above correctly it is needed starting from v3.14.
> Please correct me if I'm wrong.
Sounds correct.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
