Re: [PATCH v7 1/2] Mailbox: Add support for Platform Communication Channel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 17, 2014 at 06:17:03PM -0400, Ashwin Chaugule wrote:

> +       while (!(readw_relaxed(&generic_comm_base->status) &
> PCC_CMD_COMPLETE)) {
> +               if (retries++ < 5)
> +                       udelay(cmd_delay);
> +               else {
> +                       pr_err("PCC platform did not respond.\n");
> +                       return false;
> +               }
> +       }

You should have { } on both branches of the if but otherwise that looks
fine to me (assuming that there are enough retries).

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux