On Wed, Sep 17, 2014 at 12:13:55AM +0300, Peter Ujfalusi wrote: > ACPI_SUCCESS is defined as: > #define ACPI_SUCCESS(a) (!(a)) > > There is no need for the the double ! since there is already a macro > defined for failures: ACPI_FAILURE() > Cc: linux-acpi Thanks, Darren > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> > --- > drivers/platform/x86/intel-rst.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/intel-rst.c b/drivers/platform/x86/intel-rst.c > index d45bca3..8c6a8fe 100644 > --- a/drivers/platform/x86/intel-rst.c > +++ b/drivers/platform/x86/intel-rst.c > @@ -35,7 +35,7 @@ static ssize_t irst_show_wakeup_events(struct device *dev, > acpi = to_acpi_device(dev); > > status = acpi_evaluate_integer(acpi->handle, "GFFS", NULL, &value); > - if (!ACPI_SUCCESS(status)) > + if (ACPI_FAILURE(status)) > return -EINVAL; > > return sprintf(buf, "%lld\n", value); > @@ -59,7 +59,7 @@ static ssize_t irst_store_wakeup_events(struct device *dev, > > status = acpi_execute_simple_method(acpi->handle, "SFFS", value); > > - if (!ACPI_SUCCESS(status)) > + if (ACPI_FAILURE(status)) > return -EINVAL; > > return count; > @@ -81,7 +81,7 @@ static ssize_t irst_show_wakeup_time(struct device *dev, > acpi = to_acpi_device(dev); > > status = acpi_evaluate_integer(acpi->handle, "GFTV", NULL, &value); > - if (!ACPI_SUCCESS(status)) > + if (ACPI_FAILURE(status)) > return -EINVAL; > > return sprintf(buf, "%lld\n", value); > @@ -105,7 +105,7 @@ static ssize_t irst_store_wakeup_time(struct device *dev, > > status = acpi_execute_simple_method(acpi->handle, "SFTV", value); > > - if (!ACPI_SUCCESS(status)) > + if (ACPI_FAILURE(status)) > return -EINVAL; > > return count; > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
