Hello Mark, Arnd, Lv, On 5 September 2014 12:15, Ashwin Chaugule <ashwin.chaugule@xxxxxxxxxx> wrote: > On 5 September 2014 02:35, Zheng, Lv <lv.zheng@xxxxxxxxx> wrote: >>> >>> On 4 September 2014 21:56, Zheng, Lv <lv.zheng@xxxxxxxxx> wrote: >>> >> + spin_lock_irqsave(&chan->lock, flags); >>> >> + chan->msg_free = 0; >>> >> + chan->msg_count = 0; >>> >> + chan->active_req = NULL; >>> >> + chan->cl = cl; >>> >> + init_completion(&chan->tx_complete); >>> >> + >>> >> + if (chan->txdone_method == TXDONE_BY_POLL && cl->knows_txdone) >>> > >>> > The tab should be a space here? >>> > >>> >>> Not sure where you're seeing the tab. >> >> It is a tab here after " txdone_method". >>>> >>> >> +out_err: >>> >> + return ACPI_SUCCESS(status) ? 1 : 0; >>> > >>> > Should the return value of 1 here be -EINVAL? >>> > >>> >>> I dont think it really matters, the caller returns -EINVAL anyway. >> >> This is not a "bool" return value or "reversed bool" return value. >> Why not use errno for all "int" return value across all initialization/finalization functions? > > Ok, I'll make it consistent with errnos. Since it doesnt change the > logic of the code, I wont send out a V7 until there is any other > feedback from others. > Anymore feedback on Patchset V6? I will address Lv's comments above in V7 soon. Thanks, Ashwin -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
