On 4 September 2014 15:00, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Thursday 04 September 2014 13:24:25 Ashwin Chaugule wrote: >> On 4 September 2014 04:56, Arnd Bergmann <arnd@xxxxxxxx> wrote: >> >> >> + /* Write to the shared comm region. */ >> >> + iowrite16(cmd, &generic_comm_base->command); >> >> + >> >> + /* Write Subspace MAGIC value so platform can identify destination. */ >> >> + iowrite32((PCCS_SS_SIG_MAGIC | ss_idx), &generic_comm_base->signature); >> >> + >> >> + /* Flip CMD COMPLETE bit */ >> >> + iowrite16(0, &generic_comm_base->status); >> > >> > using writel_relaxed/writew_relaxed should be more efficient here. >> > >> >> x86 doesn't seem to have the write*_relaxed variants? They seem to >> have read*_relaxed though. > > That sounds highly inconsistent and should probably be fixed. > > You could also use writew here, which would be the same as iowrite16 > on ARM, but more efficient on x86. Used writel/writew in v6 of the patch. Thanks, Ashwin -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
