Re: [PATCH v5 1/2] Mailbox: Add support for Platform Communication Channel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 04 September 2014 10:48:00 Ashwin Chaugule wrote:
> 
> >> + * Create a virtual device to back the PCCT, so
> >> + * that the generic Mailbox framework can do its
> >> + * ref counting.
> >> + */
> >> +struct platform_device pcc_pdev = {
> >> +     .name = "PCCT",
> >> +};
> >
> > Don't declare platform devices statically in C code, just
> > use platform_create_bundle() here to create the device dynamically
> > and bind it to the driver. That will also simplify the driver
> > initalization.
> >
> 
> Nice. Didn't know about this.

It's almost always inappropriate, but I guess here it makes sense.
Normally we want drivers to be loadable when the device shows up,
but you can't do that here anyway.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux