Hi All, I've been on the receiving and of several bug reports complaining about Linux showing a backlight control (and the desktop environment a brightness slider) on non laptop machines: https://bugzilla.redhat.com/show_bug.cgi?id=1097436 https://bugzilla.redhat.com/show_bug.cgi?id=1133327 https://bugzilla.redhat.com/show_bug.cgi?id=1133329 https://bugzilla.redhat.com/show_bug.cgi?id=1133646 Note the first one is already fixed in asus-wmi.c, as that seemed best at the time. But the problem seems to be wider then just Asus motherboards, and so far all the machines with this issue seem to have this issue due to acpi-video registering a backlight interface. For the asus-wmi.c driver the following solution was chosen: /* Some Asus desktop boards export an acpi-video backlight interface, stop this from showing up */ chassis_type = dmi_get_system_info(DMI_CHASSIS_TYPE); if (chassis_type && !strcmp(chassis_type, "3")) acpi_video_dmi_promote_vendor(); That will work for 2 of the 3 new models too, the 3th model has a value of "6", aka "Mini Tower", so we could move these check to acpi-video, but then we would need to extend it to at least also check for "6", and in the future possibly others values. I'm not 100% certain simply moving the check is a good idea, I'm afraid that the check may end up triggering on some laptops, causing problems / regressions. So although I dislike quirk lists as much as the next person, as they need constant maintenance, I think that it probably is best to solve this with dmi based quirks for the boards in question, so as to avoid any chance of this causing regressions for other machines. Your input on this is greatly appreciated. Thanks & Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
