On 07/31/14 02:04, Arjun Sreedharan wrote:
> 0 is ascii for NULL. Hex digit matching should be from '0'.
> Faulty version returns true for #,$,%,& etc.
>
> Signed-off-by: Arjun Sreedharan <arjun024@xxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.
> ---
> drivers/acpi/acpi_pnp.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> index 4ddb0dc..996fa19 100644
> --- a/drivers/acpi/acpi_pnp.c
> +++ b/drivers/acpi/acpi_pnp.c
> @@ -12,6 +12,7 @@
>
> #include <linux/acpi.h>
> #include <linux/module.h>
> +#include <linux/ctype.h>
>
> static const struct acpi_device_id acpi_pnp_device_ids[] = {
> /* soc_button_array */
> @@ -320,11 +321,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> {""},
> };
>
> -static bool is_hex_digit(char c)
> -{
> - return (c >= 0 && c <= '9') || (c >= 'A' && c <= 'F');
> -}
> -
> static bool matching_id(char *idstr, char *list_id)
> {
> int i;
> @@ -335,7 +331,7 @@ static bool matching_id(char *idstr, char *list_id)
> for (i = 3; i < 7; i++) {
> char c = toupper(idstr[i]);
>
> - if (!is_hex_digit(c)
> + if (!isxdigit(c)
> || (list_id[i] != 'X' && c != toupper(list_id[i])))
> return false;
> }
>
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
