On Monday, June 30, 2014 09:29:54 AM Aaron Lu wrote: > On 06/29/2014 04:42 PM, Martin Kepplinger wrote: > > Am 2014-06-23 22:30, schrieb Martin Kepplinger: > >> Fix backlight control for Acer TravelMate B113 Laptop by adding > >> it to the video_dmi_table. > >> > >> A workaround before that was to use acpi_osi=Linux or > >> acpi_backlight=vendor on boot but even then, only the function- > >> keys worked. > >> > >> With this change there is no need for boot parameters and DE's > >> controls work as well. > >> > >> Signed-off-by: Martin Kepplinger <martink@xxxxxxxxx> > >> Tested-by: Martin Kepplinger <martink@xxxxxxxxx> > >> --- > >> drivers/acpi/video.c | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > >> index f8bc5a7..acb0670 100644 > >> --- a/drivers/acpi/video.c > >> +++ b/drivers/acpi/video.c > >> @@ -528,6 +528,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = { > >> }, > >> }, > >> { > >> + .callback = video_set_use_native_backlight, > >> + .ident = "Acer TravelMate B113", > >> + .matches = { > >> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"), > >> + DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate B113"), > >> + }, > >> + }, > >> + { > >> .callback = video_set_use_native_backlight, > >> .ident = "HP ProBook 4340s", > >> .matches = { > >> > > > > are there objections or advice on this? this would be really good to > > have, even if for 3.17. > > For v3.16, we already have this commit to make use_native_backlight > equal to 1 by default: > > commit 751109aad5834375ca9ed0dcfcd85a00cbf872b5 > Author: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > Date: Thu Jun 5 22:47:35 2014 +0200 > > ACPI / video: Change the default for video.use_native_backlight to 1 Nevertheless, we may need the blacklist entries in case we need to revert the above commit and also in case we want them to be backported to -stable (or LTSI etc.). Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html