Re: [PATCH 5/7 REVISION] trace, RAS: Add eMCA trace event interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 12 Jun 2014 23:01:17 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Thu, 12 Jun 2014 22:19:57 -0400
> "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx> wrote:
> 
> > On Thu, Jun 12, 2014 at 09:28:08AM -0400, Steven Rostedt wrote:
> > > > +	TP_STRUCT__entry(
> > > > +		__field(u32, err_seq)
> > > > +		__field(u8, etype)
> > > > +		__field(u8, sev)
> > > > +		__field(u64, pa)
> > > > +		__field(u8, pa_mask_lsb)
> > > > +		__array(u8, fru_id, sizeof(uuid_le))
> > > > +		__string(fru_text, fru_text)
> > > > +		__array(u8, data, sizeof(struct cper_mem_err_compact))
> > > 
> > > The above array works, but I'm wondering why you don't just use the
> > > types themselves?
> > > 
> > > That is:
> > > 
> > > 		__field(uuid_le, fru_id)
> > > 		__field(struct cper_mem_err_compact, data)
> > > 
> > Every time when I use above codes I will hit some compiler error like
> > "error: conversion to non-scalar type requested". It looks some
> > data types like above (unless typedef) can't be used in __field.
> > Is it true? How to fix that?
> > 
> 
> Ah, that's a bug in the ftrace.h file. I'll need to test this against
> it to see what error it gives. I'll work on that tomorrow as it's
> bedtime for me now.

Wait, I take that back. I was thinking the error was with the
__array(). A __field() should work fine!

Can you post me the patch you did and the error you get when you
compile.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux