On Wednesday, June 04, 2014 01:09:50 PM Lee Jones wrote: > Any drivers which support ACPI and Device Tree probing need to include > both respective header files. Without this patch, if a driver is being > used on a platform which does not support ACPI and subsequently does not > have the config option enabled, but includes linux/acpi.h the build > breaks with: > > In file included from ../include/acpi/platform/acenv.h:150:0, > from ../include/acpi/acpi.h:56, > from ../include/linux/match.h:2, > from ../drivers/i2c/i2c-core.c:43: > ../include/acpi/platform/aclinux.h:73:23: > fatal error: asm/acenv.h: No such file or directory > #include <asm/acenv.h> > ^ Which kernel does this happen with? > Cc: Lv Zheng <lv.zheng@xxxxxxxxx> > Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > Cc: linux-acpi@xxxxxxxxxxxxxxx > Cc: devel@xxxxxxxxxx > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > --- > include/acpi/platform/aclinux.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h > index cd1f052..fdf7663 100644 > --- a/include/acpi/platform/aclinux.h > +++ b/include/acpi/platform/aclinux.h > @@ -70,9 +70,10 @@ > #ifdef EXPORT_ACPI_INTERFACES > #include <linux/export.h> > #endif > -#include <asm/acenv.h> > > -#ifndef CONFIG_ACPI > +#ifdef CONFIG_ACPI > +#include <asm/acenv.h> > +#else > > /* External globals for __KERNEL__, stubs is needed */ > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
