Re: [PATCH 1/2] ACPICA: Tables: Add mechanism to control early table checksum verification.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, May 30, 2014 10:07:31 AM Lv Zheng wrote:

[cut]

> diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
> index b5f7132..380828d 100644
> --- a/include/acpi/acpixf.h
> +++ b/include/acpi/acpixf.h
> @@ -162,6 +162,14 @@ ACPI_INIT_GLOBAL(u8, acpi_gbl_create_osi_method, TRUE);
>  ACPI_INIT_GLOBAL(u8, acpi_gbl_use_default_register_widths, TRUE);
>  
>  /*
> + * Optionally verify the table checksum before installation. Set this to

What about "Whether or not to verify ..." instead of "Optionally verify ..."?

> + * TRUE to verify the table checksum before install it to the table
> + * manager. Note that some OSPMs cannot do large mappings during the
> + * certain stages.

The "Note that ..." thing is completely unuseful here, because it is not
particularly clear why being unable to use large mappings is related to
this option (I know it is, but a casual reader may not know that).

What about "Note that enabling this option causes errors to happen in
some OSPMs during early initialization stages" instead?

> Default is behavior is to do such verification.
> + */

Please fix the double "is".

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux