On Fri, May 23, 2014 at 12:11:43PM +0200, Borislav Petkov wrote: > + TP_printk("%d %s error: %s %s %llx (mask lsb: %x), %s%s", What if pa_mask_lsb not existing? It will show something like: extlog_mem_event: 1 corrected error: unknown DIMM location: Memriser1 CHANNEL A DIMM 0 0x0000000074516000 (mask lsb: ), node: 0 card: 0 module: 0 rank: 0 bank: 0 row: 7329 column: 656 FRU: 00000000-0000-0000-0000-000000000000 even worse, if pa not existed, it will show: extlog_mem_event: 1 corrected error: unknown DIMM location: Memriser1 CHANNEL A DIMM 0 (mask lsb: ), node: 0 card: 0 module: 0 rank: 0 bank: 0 row: 7329 column: 656 FRU: 00000000-0000-0000-0000-000000000000 What I want to do is to make output format more graceful. > + __entry->error_number, > + cper_severity_str(__entry->severity), > + cper_mem_err_type_str(__entry->etype), > + __get_str(dimm_info), > + __entry->pa, > + __entry->pa_mask_lsb, > + __get_str(mem_loc), > + __get_str(fru)) > +); >
Attachment:
signature.asc
Description: Digital signature