On Tue, Apr 15, 2014 at 08:05:54PM +0200, Borislav Petkov wrote:
> > Because 128 is not enough once all fields in error record exist, and 256 looks
> > a little bit tough so I choose a bigger value. No spec for it. I just hope
>
> Tough? How? Not enough?
>
We have different CPER error type. For example, for processor error type,
it has following definition:
struct cper_sec_proc_generic {
__u64 validation_bits;
__u8 proc_type;
__u8 proc_isa;
__u8 proc_error_type;
__u8 operation;
__u8 flags;
__u8 level;
__u16 reserved;
__u64 cpu_version;
char cpu_brand[128];
__u64 proc_id;
__u64 target_addr;
__u64 requestor_id;
__u64 responder_id;
__u64 ip;
};
If we want to show it in string format, 256 bytes should be not enough. But
by now we don't use this macro for processor error type so I will shrink it
to 256 bytes and add a comment for it.
Attachment:
signature.asc
Description: Digital signature
