Re: [PATCH 2/5] CPER: Adjust code flow of some functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 15, 2014 at 05:24:42AM -0400, Chen, Gong wrote:
> That's why I export this spinlock because in another patch(3/5) I use
> this spinlock to surround whole handling procedure of tracepoint.
>
> If exporting this spinlock directly is too ugly, I can use an inline
> function to get the same purpose.

You still haven't answered...

> > So you have to think about all possible call paths ending here and
> > *then* introduce proper sync.
^^^^^^^^^^^^^

this question. Do we even *need* the locking? If so, why? What paths are
going to end there?

The answers to those questions will give you the correct synchronization.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux