Re: [PATCH RFC] i2c algo, Add i2c-algo-i801 driver [v1]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2014-04-10 at 15:15 -0400, Prarit Bhargava wrote:
> 
> On 04/09/2014 01:09 PM, Matthew Garrett wrote:
> > Not really. These are an internal implementation detail, not an exported
> > interface. We try to write drivers for exported interfaces, even if
> > they're not documented.
> 
> Aren't the methods the exported interface?  I'm obviously missing something :)

No. The device doesn't have a _HID(), so they're internal methods.

> > Imagine an i2c chip with indexed register access. What stops:
> > 
> > CPU0 (i2c):		CPU1 (ACPI):
> > SBWB register address
> > 			SBWB register address
> > SBRB register value
> > 			SBRB register value
> > 
> > and CPU0 getting back the wrong value?
> 
> I thought that the "Serialized" keyword in the methods specifically indicate
> that this cannot happen.

It means you can't run the same method twice at the same time, but in
the above case you're not doing that. Nothing ensures that SBWB can't be
run again before SBRB is run.

-- 
Matthew Garrett <matthew.garrett@xxxxxxxxxx>
��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux