RE: [PATCH 1/4] tools/power/acpi: Minor bugfixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Thomas

This one looks fine.
Build tests are all passed.
Thanks for fixing issues.

Best regards
-Lv

> From: Thomas Renninger [mailto:trenn@xxxxxxx]
> Sent: Monday, April 07, 2014 9:17 PM
> 
> - bindir is created, but sbindir is used -> fix that
> - the debug parts are there twice (copy paste bug?). Remove one of the
>   exact same parts
> 
> Signed-off-by: Thomas Renninger <trenn@xxxxxxx>
> ---
>  tools/power/acpi/Makefile |   11 +----------
>  1 files changed, 1 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/power/acpi/Makefile b/tools/power/acpi/Makefile
> index d9186a2..c2c0f20 100644
> --- a/tools/power/acpi/Makefile
> +++ b/tools/power/acpi/Makefile
> @@ -89,15 +89,6 @@ else
>  	STRIPCMD = $(STRIP) -s --remove-section=.note --remove-section=.comment
>  endif
> 
> -# if DEBUG is enabled, then we do not strip or optimize
> -ifeq ($(strip $(DEBUG)),true)
> -	CFLAGS += -O1 -g -DDEBUG
> -	STRIPCMD = /bin/true -Since_we_are_debugging
> -else
> -	CFLAGS += $(OPTIMIZATION) -fomit-frame-pointer
> -	STRIPCMD = $(STRIP) -s --remove-section=.note --remove-section=.comment
> -endif
> -
>  # --- ACPIDUMP BEGIN ---
> 
>  vpath %.c \
> @@ -128,7 +119,7 @@ clean:
>  	-rm -f $(OUTPUT)acpidump
> 
>  install-tools:
> -	$(INSTALL) -d $(DESTDIR)${bindir}
> +	$(INSTALL) -d $(DESTDIR)${sbindir}
>  	$(INSTALL_PROGRAM) $(OUTPUT)acpidump $(DESTDIR)${sbindir}
> 
>  install-man:
> --
> 1.7.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux