On 20.03.2014 14:53, Ashwin Chaugule wrote:
On 20 March 2014 09:48, Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx> wrote:
Although I generally agree that mapping/umapping should be done in the
caller, it seems umapping in this manner is baked in APCI core code
and I didn't want to change too many things at once without causing
unintentional side effects elsewhere.
You will not cause any side effects if unmapping will stay in
acpi_table_parse_entries().
What if callers only call acpi_parse_entries()?
acpi_parse_entries() requires already mapped MADT table and as you
agreed on caller mapping/unmapping responsibility, caller need to unmap
MADT table after all. I mean sth like that:
1. Get MADT table pointer
2. Map MADT table
3. Use acpi_parse_entries() as many times as you wish (some calls can
return error but you don't have to map MADT again)
4. Unmap MADT table
What do you think?
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
