On Mon, 2014-03-10 at 15:45 +0000, Matthew Garrett wrote: > On Mon, Mar 10, 2014 at 09:56:25AM +0000, Adrian Huang12 wrote: > > + if (status == AE_NOT_FOUND && > > Why limit it to not found? Just for the undefined _OSC object in order to follow ACPI5.0. Looks like another approach should be implemented to address this issue. Is this what you were thinking of: we should never evaluate the _OSC object if it is the PCI root bridge? > I suspect that we should never be basing our > ASPM policy on the behaviour of PCI (rather than PCIe) bridges. Yes, agree since the ASPM functionality is supported only for PCIe. Do you agree we should never evaluate the _OSC object if it is the PCI root bridge? > I'd recommend changing the patch subject line, too - there's nothing > Haswell specific about this. Thanks. I will change the subject line. :-) -- Adrian ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f