On 2014/1/3 8:05, Yinghai Lu wrote: > iommu irq's irq_desc should be on local node ram. > > Fix the return value checking problem. > create_irq() will return -1 when fail to allocate. > create_irq_nr() will return 0 when fail to allocate. > here only check !irq, so need to change it to use create_irq_nr instead. > > -v2: According to Sebastian, add cc to stable. > > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> > Cc: Joerg Roedel <joro@xxxxxxxxxx> > Cc: Donald Dutile <ddutile@xxxxxxxxxx> > Acked-by: Donald Dutile <ddutile@xxxxxxxxxx> > Cc: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > --- > drivers/iommu/dmar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index 8b452c9..f4eaa50 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -1277,7 +1277,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu) > if (iommu->irq) > return 0; > > - irq = create_irq(); > + irq = create_irq_nr(0, iommu->node); Hi Yinghai, How about create_irq_nrq(1, iommu->node) here to clearly state that 0 is not a valid irq number for dmar here? Thanks! Gerry > if (!irq) { > pr_err("IOMMU: no free vectors\n"); > return -EINVAL; > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html