On 2014年02月18日 22:06, Joe Perches wrote:
On Tue, 2014-02-18 at 21:55 +0800, Hanjun Guo wrote:
This patch just do some clean up to replace printk with pr_*,
no functional change.
trivial note:
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
[]
@@ -55,8 +55,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
{
struct acpi_madt_local_apic *p =
(struct acpi_madt_local_apic *)header;
- printk(KERN_INFO PREFIX
- "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
+ pr_info(PREFIX "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
p->processor_id, p->id,
(p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
It'd be nice to realign the additional lines to the open
parenthesis, here and everywhere else in this patch
pr_info(PREFIX "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
p->processor_id, p->id,
(p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
Thanks for your comments, will update patch 1/5 and 5/5 follow your
suggestion :)
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
