Sorry, I've pressed wrong "Reply" button
---------- Forwarded message ----------
From: Alexander Mezin <mezin.alexander@xxxxxxxxx>
Date: 2014-02-10 16:38 GMT+07:00
Subject: Re: [PATCH 1/2] ACPI / AC: Notify when state changes in get_ac_property
To: Lan Tianyu <lantianyu1986@xxxxxxxxx>
2014-02-10 10:15 GMT+07:00 Lan Tianyu <lantianyu1986@xxxxxxxxx>:
> 2014-02-10 Alexander Mezin <mezin.alexander@xxxxxxxxx>:
>> 2014-02-10 9:34 GMT+07:00 Lan Tianyu <lantianyu1986@xxxxxxxxx>:
>>> 2014-02-10 Lan Tianyu <lantianyu1986@xxxxxxxxx>:
>>>> 2014-02-10 10:16 GMT+08:00 Alexander Mezin <mezin.alexander@xxxxxxxxx>:
>>>>> 2014-02-10 8:29 GMT+07:00 Lan Tianyu <lantianyu1986@xxxxxxxxx>:
>>>>>> 2014-02-08 Alexander Mezin <mezin.alexander@xxxxxxxxx>:
>>>>>>> 2014-02-08 13:33 GMT+07:00 Lan Tianyu <lantianyu1986@xxxxxxxxx>:
>>>>>> Hi:
>>>>>> What's the benefit of the second patch without this patch?
>>>>>> So far, bios sends the ACPI notify event of power change to AC driver and
>>>>>> the driver would change status and send uevent. That seems enough.
>>>>> Without second patch AC adapter's status isn't updated on my laptop.
>>>>
>>>> commit 50a2bc5429f can't fix this issue.
>>> Sorry. commit 50a2bc5429f can't fix this issue?
>> No, it doesn't solve the problem. But before it AC state didn't update
>> even when I run "acpi -a". There was no way other than reboot.
>
> Ok. You mean AC state didn't update before running "acpi -a" with commit
> 50a2bc5429f, right?
No. I mean AC state didn't update when I run "acpi -a", before I made commit
50a2bc5429f. Or maybe I just don't understand you.
>
> How do you check the AC state? via /sys/class/power_supply/ACXX/online?
No. I check it by looking at KDE's power manager icon. Reading
/sys/class/power_supply/AC/online has the same effect as "acpi -a"
(without 50a2bc5429f state doesn't update, with 50a2bc5429f - state updates,
and power manager also gets the notification).
Also, I checked it using UPower dbus interface and qbus.
The same results as with power manager.
>
> What does acpi_listen show when plug or unplug adaptor?
With second patch ("ACPI / battery: check AC adapter's state when
battery state changes"):
battery PNP0C0A:00 00000001 00000001
battery PNP0C0A:00 00000080 00000001
PNP0C14:00 00000080 00000000
ac_adapter ACPI0003:00 00000000 00000000
processor LNXCPU:00 00000082 00000000
battery PNP0C0A:00 00000000 00000001
battery PNP0C0A:00 00000080 00000001
PNP0C14:00 00000080 00000000
processor LNXCPU:00 00000082 00000000
battery PNP0C0A:00 00000080 00000001
ac_adapter ACPI0003:00 00000000 00000001
Without the patch - the same, but without lines starting with "ac_adapter".
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
